Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test pr 1263 #1267

Closed
wants to merge 18 commits into from
Closed

Test pr 1263 #1267

wants to merge 18 commits into from

Conversation

sfc-gh-aalam
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@zaramzamzam
add regression test for old behavior
0553eba 
- this should fail once closing sessions in stored procedures is a noop
@zaramzamzam
write a warning when closing a session inside a stored procedure
8b11568 
- instead of throwing an error a warning is written when closing a session inside a
  stored procedure
@zaramzamzam
remove skip condition for session closing integration test when insid…
69ca98b 
…e a stored procedure

- skip should not be needed anymore due to the closing of a session being a no-op
  when inside a stored procedure
@zaramzamzam
rename test functions
56459d8
@zaramzamzam
add no-op functionality when closing sessions in stored procedure
e371bad
@zaramzamzam
update skif if reason
72fef95 
- test cannot be run because creating a session in stored procedures is not allowed
@zaramzamzam
rerun pre-commit for formatting
4239b78
@zaramzamzam
combine log tests for different log levels into one using pytest para…
eaad7b5 
…metrize
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review February 23, 2024 00:31
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner February 23, 2024 00:31
@sfc-gh-aalam sfc-gh-aalam marked this pull request as draft February 23, 2024 00:32
@sfc-gh-aalam sfc-gh-aalam mentioned this pull request Feb 28, 2024
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
@sfc-gh-aalam sfc-gh-aalam deleted the test_pr_1263 branch July 17, 2024 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aalam @zaramzamzam